HADOOP-19014. Jackson 2.14.3 requiring jsr311-compat#6370
Closed
pjfanning wants to merge 2 commits intoapache:trunkfrom
Closed
HADOOP-19014. Jackson 2.14.3 requiring jsr311-compat#6370pjfanning wants to merge 2 commits intoapache:trunkfrom
pjfanning wants to merge 2 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> |
Contributor
There was a problem hiding this comment.
should have a comment above to explain, maybe something on L72 to say why we've had problems with jackson updates
Member
Author
There was a problem hiding this comment.
I'll add some comments and recheck the dependency scopes.
| <dependency> | ||
| <groupId>com.github.pjfanning</groupId> | ||
| <artifactId>jsr311-compat</artifactId> | ||
| <scope>runtime</scope> |
Contributor
There was a problem hiding this comment.
what will break if this is not on the classpath?
Contributor
|
I'm happy with this, just need to understand if there are any problems with it being optional we will need to add in release notes as incompatible and explain the issue and why the jar should be excluded if you do have the jax-rs stuff on the cp, and that findclass can always be used to work out where the class is from |
4 tasks
pjfanning
force-pushed
the
HADOOP-19014-jackson
branch
from
025ad17 to
a08b99e
Compare
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
I'm going to come back to this but in a few weeks. There are some incompatibilities showing up in testing and I want to have a closer look. I have a few days off this week so I don't want to delay the 3.4.0 branching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19014
see https://github.com/pjfanning/jsr311-compat/
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?